Re: [Xen-devel] [PATCH 1/2] Virtual frame buffer: frontend

[Markus Armbruster <armbru@xxxxxxxxxx>]

Laurent Vivier <Laurent.Vivier@xxxxxxxx> writes:

> Hi,
>
> my domain hangs when I load xenfb module.
>
> The sequence is:
> dom0# sdlfb <id>
> ...
> domU# modprobe fbcon
> domU# modprobe xenkbd
> domU# modprobe xenfb
> ... HANGS HERE ....
>
> I found that it hangs in xenfb_event_handler() because info->page->in_prod and
> info->page->in_cons are not initialized correctly.

You're right.  I missed that error, then had the bad luck that it
happened to work for me every time.

> I propose following correction:
>
> Index: xen-3.0-testing.hg/linux-2.6.16.13-xen/drivers/xen/xenfb/xenfb.c
> ===================================================================
> --- xen-3.0-testing.hg.orig/linux-2.6.16.13-xen/drivers/xen/xenfb/xenfb.c
> 2006-07-28 12:58:47.000000000 +0200
> +++ xen-3.0-testing.hg/linux-2.6.16.13-xen/drivers/xen/xenfb/xenfb.c
> 2006-07-28 15:28:23.000000000 +0200
> @@ -414,6 +414,8 @@
>         info->page->depth = 32;
>         info->page->line_length = (info->page->depth / 8) * info->page->width;
>         info->page->mem_length = xenfb_mem_len;
> +       info->page->in_cons = info->page->in_prod = 0;
> +       info->page->out_cons = info->page->out_prod = 0;

Works for me.

>         ret = bind_evtchn_to_irqhandler(info->evtchn, xenfb_event_handler,
>                                         0, "xenfb", info);
>
>
> Regards,
> Laurent

Sorry for the slow reply, I was sick.

Thanks!

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel