Re: [Xen-devel] [PATCH][LINUX] use machine_emergency_restart() from the generic header.

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 8/8/06 1:46 pm, "Jimi Xenidis" <jimix@xxxxxxxxxxxxxx> wrote:

> hmm, there are a lot of x86 isms in this file.. I think having all
> these ifdefs in ./drivers will be problematic to the Linux
> integration cause.
> At some point I could see us trying to remove/abstract them anyway.
> 
> Perhaps we could prefix all the methods with "xen_" and have arch
> specific code _in_ arch specific directories call it accordingly?
> 
> I would also like to separate the suspend code from the reboot/halt
> code into different files since thats is cleaner to select that
> support by CONFIG_, thoughts?

All sound like good suggestions. It'll be necessary for upstream merging
anyway, as it'll need to hook under arch-specific paravirt_ops.

I'd take patches to split into separate source files, certainly. And the
xen_ prefixing probably too.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel