[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] shared_info size and padding fixes



>>      DEFINE(IA64_SWITCH_STACK_SIZE, sizeof (struct switch_stack));
>>      DEFINE(IA64_CPU_SIZE, sizeof (struct cpuinfo_ia64));
>>      DEFINE(UNW_FRAME_INFO_SIZE, sizeof (struct unw_frame_info));
>> -    DEFINE(SHARED_INFO_SIZE, sizeof (struct shared_info));
>>
>>      BLANK();
>>      DEFINE(IA64_MCA_CPU_INIT_STACK_OFFSET, offsetof (struct
ia64_mca_cpu,
>
>Please, do not remove this define.  It is used to check the struct is
not 
>bigger than a page!

Checking this should be done with BUILD_BUG_ON() in a .c file, and
hence
not require an entry in asm-offsets.c.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.