Re: [Xen-devel] [PATCH][XEN] fix missing header and gcc warning

[Markus Armbruster <armbru@xxxxxxxxxx>]

Jimi Xenidis <jimix@xxxxxxxxxxxxxx> writes:

> Explicaly include <xen/domain_page.h> for map_domain_page() and fix warning.
> gcc says:
>   warning: pointer of type 'void *' used in arithmetic
> looks like only powerpc has -Wpointer-arith turned on.
>
> Signed-off-by: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
>
> ---
> diff -r c87f89fc7be4 xen/common/grant_table.c
> --- a/xen/common/grant_table.c        Sun Aug 13 12:53:19 2006 -0400
> +++ b/xen/common/grant_table.c        Sun Aug 13 13:02:03 2006 -0400
[...]
> @@ -902,7 +903,9 @@ __gnttab_copy(
>      sp = map_domain_page(s_frame);
>      dp = map_domain_page(d_frame);
>  
> -    memcpy(dp + op->dest.offset, sp + op->source.offset, op->len);
> +    memcpy((void *)((ulong)dp + op->dest.offset),
> +           (void *)((ulong)sp + op->source.offset),
> +           op->len);

I find this needlessly ugly.  Why not just declare sp and dp char *?

>  
>      unmap_domain_page(dp);
>      unmap_domain_page(sp);
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel