Re: [Xen-devel] [PATCH][XEN]xm dump command add on

[John Levon <levon@xxxxxxxxxxxxxxxxx>]

On Mon, Aug 14, 2006 at 05:03:59PM +0900, Ken Hironaka wrote:

> +        if((sts=copy_from_domain_page(xc_handle, domid, page_array[i], 
> dump_mem))<0)
> +            cpy_sts=sts;
> +
> +    if(cpy_sts!=0)
> +        goto error_out;

Should be:

        if ( ... )

> +        try:
> +            log.info("Dumping Core for Domain %s (%d).", dominfo.getName(),
> +                     dominfo.getDomid())

Better as "Domain core dump requested for domain %s (%d)" ?

> +    if not live:
> +        print "pausing domain:%s ..." % str(dom)
> +        server.xend.domain.pause(dom)

Is it really worth mentioning the pause? It doesn't take any amount of
time, surely.

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel