Re: [PATCH] Re: [Xen-devel] [RFC] support console resolutions better than 80x25

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 14/8/06 6:45 pm, "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx> wrote:

> Sounds like it'd be better to make slot 0 the default and require override
> if the user really cares about the BIOS font data. That sounds a lot less
> likely than someone trying to use the higher-res text mode on an ATI adapter
> and getting confused when it doesn't work!
> 
> It'd be nice if we could also have the Linux-style linearfb code, so we
> could use the higher res graphics modes. I suppose that would be a lot more
> work though, and should fit in the framework that this patch provides (in
> particular, the info structure passed to domain0 should be able to support
> that, right)?

Also, the union in start_info would be clearer as (assuming this doesn't
change the offset/size of any fields, which I don't think it does):
 union {
    struct {
       console_mfn/evtchn
    } normal;
    struct {
       con_info_ofs/size
    } init;
 } domain;

Apart from being clearer, the Sun compiler doesn't like anonymous unions so
we try to avoid them.

By the way: please just send further patches against your previous
mega-patch. :-)

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel