Re: [PATCH] Re: [Xen-devel] [RFC] support console resolutions better than 80x25

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 15/8/06 5:11 pm, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

>> * What do the values of the video_type and txt_mode fields mean? Do we need
>> to provide enumerations, or refer to VESA type codes?
> 
> video_type is the equivalent of Linux' orig_video_isVGA (which is namely used
> to distinguish between VGA text and VESA lfb based screen setups), whereas
> txt_mode is the equivalent of Linux' orig_video_mode, representing the
> specific
> (BIOS INT 10) mode that was in effect when booting.
> While clearly these could be combined into a single field, keeping things the
> Linux
> way seemed simpler to me.

Could video_type just be a is_lfb boolean? Do we think we'll ever support
anything other than vga text modes and lfb gfx modes? That's all Linux's
video.S seems to support as values for the isVGA field.

We don't seem to really use txt_mode. We always set it to 3: that can't be
the right value for all the different text modes we support, can it? Anyway,
if it represents an int10 mode value then it's really a vga_mode rather than
just a txt_mode, isn't it? Given this field is hardly used in Linux (just to
gate setup of vgacon.c afaics) it seems this field could simply be removed.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel