[Xen-devel] Re: [NET] front: Fix features on resume when csum is off

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 16/8/06 2:11 am, "Herbert Xu" <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> [NET] front: Fix features on resume when csum is off
> 
> When the netfront driver is resumed the features are renegotiated with
> the backend.  However, I forgot take into account the status of the TX
> checksum setting.  When TX checksum is disabled by the user, we cannot
> enable SG or TSO since both require checksum offload.  This patch makes
> xennet check the checksum setting before renegotiating SG or TSO.

This seems a bit odd. Shouldn't it be up to the network stack to not use
SG/TSO if it can't use them with a non-checksumming interface? What is the
failure mode currently?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel