Re: [Xen-devel] [PATCH] xentrace event mask for memory management class

[Mark Williamson <mark.williamson@xxxxxxxxxxxx>]

> Since TRC_MEM is defined as 0x000af000 in xen/include/public/trace.h,
> TRC_MEM = TRC_SCHED | TRC_VMX.  I feel strange about this.  I do not
> think scheduling is a part of memory management.  Am I right?

Looks to me like it's probably a typo that hasn't been spotted before - well 
done.

> This patch defines TRC_MEM as an independent event mask.  In addition,
> xentrace accepts '-e mem' option so that it puts memory management
> events in trace buffers.  The manual page (xentrace.8) is also
> modified accordingly.
>
> Tested by compiling on x86 and ia64, booting Dom0 and DomU, taking a
> xentrace log with '-e mem' option.

Thanks for the thorough testing and for updating the man page!

The patch looks fine to me.

+1

Cheers,
Mark

-- 
Dave: Just a question. What use is a unicyle with no seat?  And no pedals!
Mark: To answer a question with a question: What use is a skateboard?
Dave: Skateboards have wheels.
Mark: My wheel has a wheel!

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel