[Xen-devel] Re: [Xen-changelog] [xen-unstable] Replace dom0_ops hypercall with three new hypercalls:

[Hollis Blanchard <hollisb@xxxxxxxxxx>]

On Sat, 2006-08-26 at 15:10 +0000, Xen patchbot-unstable wrote:
> # HG changeset patch
> # User kfraser@xxxxxxxxxxxxxxxxxxxxx
> # Node ID 86d26e6ec89b3aba5512d981838caea043b157ab
> # Parent  9091331dfb353212781622f3c9020492cb049178
> Replace dom0_ops hypercall with three new hypercalls:
>  1. platform_op -- used by dom0 kernel to perform actions on the
>     hardware platform (e.g., MTRR access, microcode update, platform
>     quirks, ...)
>  2. domctl -- used by management tools to control a specified domain
>  3. sysctl -- used by management tools for system-wide actions

I see this wasn't strictly moving code around... you made at least the
following change:

-struct dom0_getmemlist {
-    /* IN variables. */
-    domid_t       domain;
-    uint64_t max_pfns;
-    XEN_GUEST_HANDLE(xen_pfn_t) buffer;
-    /* OUT variables. */
-    uint64_t num_pfns;
-};
+struct xen_domctl_getmemlist {
+    /* IN variables. */
+    uint64_t max_pfns;
+    XEN_GUEST_HANDLE_64(ulong) buffer;
+    /* OUT variables. */
+    uint64_t num_pfns;
+};

In particular, the handle changed from xen_pfn_t to ulong, and that
breaks this code:
int xc_get_pfn_list(int xc_handle,
                    uint32_t domid,
                    xen_pfn_t *pfn_buf,
                    unsigned long max_pfns)
{
    ...
    set_xen_guest_handle(domctl.u.getmemlist.buffer, pfn_buf);




Revert build break from dom0_ops split.
Signed-off-by: Hollis Blanchard <hollisb@xxxxxxxxxx>

diff -r 512078953bbb xen/include/public/domctl.h
--- a/xen/include/public/domctl.h       Fri Aug 18 05:39:01 2006 -0400
+++ b/xen/include/public/domctl.h       Tue Aug 29 13:43:57 2006 -0500
@@ -73,7 +73,7 @@ struct xen_domctl_getmemlist {
 struct xen_domctl_getmemlist {
     /* IN variables. */
     uint64_t max_pfns;
-    XEN_GUEST_HANDLE_64(ulong) buffer;
+    XEN_GUEST_HANDLE_64(xen_pfn_t) buffer;
     /* OUT variables. */
     uint64_t num_pfns;
 };


-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel