[Xen-devel] [PATCH] [UNTESTED] Fix sentinel in call to execlp in tools/iommu/vnc.c

[Harry Butterworth <harry@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>]

On Wed, 2006-08-30 at 10:58 -0500, David F Barrera wrote:
> August 30, 2006, using xen-unstable changeset:
> 
> changeset:   11288:a47951e59cbf

> ISSUES:
> 
> x86_64 **BLOCKED (SLES 10 on IBM HS20 Blade 8843)
> 
> Unable to start xen on this machine. Build log shows:
> 
> /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:1272: 
> warning: missing sentinel in function call
> make[3]: *** [vnc.o] Error 1
> make[2]: *** [subdir-i386-dm] Error 2
> make[1]: *** [ioemu] Error 2
> make: *** [all] Error 2
> ...
> make[3]: *** [vnc.o] Error 1
> make[2]: *** [subdir-i386-dm] Error 2
> make[1]: *** [ioemuinstall] Error 2
> make: *** [install] Error 2"

This patch should fix your problem here.  I have not tested it.  Please
give it a go and report whether it is OK to be committed to the tree.

The issue is that 0 on a 64 bit machine is a 32 bit integer whereas the
sentinel needs to be a 64 bit null pointer for the code to be correct.

Signed-off-by: Harry Butterworth <butterwo@xxxxxxxxxx>

Attachment: sentinel.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel