[Xen-devel] Re: [PATCH 01/04] Kexec / Kdump: Generic code

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 17/10/06 2:25 am, "Horms" <horms@xxxxxxxxxxxx> wrote:

> TYPE_DEFAULT is kexec, TYPE_CRASH is kdump.
> 
> Its just to avoid a from_guest. If you think that isn't worthwhile
> we can fold it into the structural parameter.

Yes please. This isn't performance critical. Folding will make the interface
better match other hypercalls.

> I certainly saw the problem. I'll do some more investigations.
> 
> ... Actually now that I think about it for a moment, perhaps it was
> inheriting -Wall from CFLAGS in my environment. If that is the case,
> then I think the work-around I added is valid.:wq

Xen is always built with -Wall. I simply don't believe this can be a valid
warning message. There's nothing special about __xchg() that should cause
complaint when its return value is discarded (a common thing to do in C).
Can you repro the problem on vanilla versions of gcc (straight from
gnu.org)?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel