[Xen-devel] Re: [PATCH 01/04] Kexec / Kdump: Generic code

[Horms <horms@xxxxxxxxxxxx>]

On Tue, Oct 17, 2006 at 07:56:37AM +0100, Keir Fraser wrote:
> 
> 
> 
> On 17/10/06 2:25 am, "Horms" <horms@xxxxxxxxxxxx> wrote:
> 
> > TYPE_DEFAULT is kexec, TYPE_CRASH is kdump.
> > 
> > Its just to avoid a from_guest. If you think that isn't worthwhile
> > we can fold it into the structural parameter.
> 
> Yes please. This isn't performance critical. Folding will make the interface
> better match other hypercalls.

The main thing that I am concerned about is, that in the
case that dom0 panics, and we are asking the hypercall to take a dump
for us, do we really want a copy_from guest in that path?
It seems to me that its best to have that path as simple as possible.
But I do argree that it comes at the expense of making the interface
a bit unclean.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel