Re: [Xen-devel] [PATCH] Introduce Makefile config fragments for OS-specific differences.

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 17/10/06 13:42, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote:

> -ifneq ($(debug),y)
> -# Optimisation flags are overridable
> -CFLAGS    ?= -O2 -fomit-frame-pointer
> -CFLAGS    += -DNDEBUG
> -else
> -# Less than -O1 produces bad code and large stack frames
> -CFLAGS    ?= -O1 -fno-omit-frame-pointer
> -CFLAGS    += -g
> -endif

Generally this patch is fine, but does the above chunk have to be made
OS-specific? Does Solaris specifically have something against
-fomit-frame-pointer?

Also, moving KERNEL_REPO/KERNELS/XKERNELS seems unnecessary. There are still
rules consuming those variables in the root Makefile, so leaving
KERNELS/XKERNELS nearby makes sense to me.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel