Re: [Xen-devel] [PATCH] Introduce Makefile config fragments for OS-specific differences.

[John Levon <levon@xxxxxxxxxxxxxxxxx>]

On Tue, Oct 17, 2006 at 04:09:22PM +0100, Keir Fraser wrote:

> > -ifneq ($(debug),y)
> > -# Optimisation flags are overridable
> > -CFLAGS    ?= -O2 -fomit-frame-pointer
> > -CFLAGS    += -DNDEBUG
> > -else
> > -# Less than -O1 produces bad code and large stack frames
> > -CFLAGS    ?= -O1 -fno-omit-frame-pointer
> > -CFLAGS    += -g
> > -endif
> 
> Generally this patch is fine, but does the above chunk have to be made
> OS-specific? Does Solaris specifically have something against
> -fomit-frame-pointer?

Yes, it's a fundamental principle that all the software we deliver can
produce meaningful stack traces.

> Also, moving KERNEL_REPO/KERNELS/XKERNELS seems unnecessary. There are still
> rules consuming those variables in the root Makefile, so leaving
> KERNELS/XKERNELS nearby makes sense to me.

This is specifically to make sure that KERNELS is empty on Solaris.
Otherwise, we have to add some $(XEN_OS) gook to $(XEN_ROOT)/Makefile.
Hopefully these are going away soonish anyway ;)

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel