[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH] remove HVM halt timer


  • To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Li, Xin B" <xin.b.li@xxxxxxxxx>
  • Date: Fri, 10 Nov 2006 19:15:05 +0800
  • Delivery-date: Fri, 10 Nov 2006 03:15:48 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AccEnswNUkAD/BhaQT+W4uZ/emiWdAAAYqyKAABK//AAAKXPCwAAhOTwAAQ0ySUAAHoC4A==
  • Thread-topic: [Xen-devel] [PATCH] remove HVM halt timer

>> New patch attached.
>
>Why did you remove the test of VCPU_running in pt_timer_fn()? 
>There's no
>need to continue running the timer when a vcpu is descheduled, 
>as long as it
>fires the first time (which it will).
>

At the time of the test, it's should always be true because the callback
can only be executed when current is the target vcpu, and when hvm vcpu
is scheduled out, the timer will be stopped, and so can not run.
-Xin


>Apart from that it looks good so I'll check in the rest.
>
> -- Keir
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.