[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Allow mini-os to unbind all evtchns


  • To: Grzegorz Milos <gm281@xxxxxxxxx>, Jacob Gorm Hansen <jacobg@xxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Wed, 29 Nov 2006 12:25:37 +0000
  • Cc: xen-devel <Xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 29 Nov 2006 04:25:41 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AccTsXliuAn5ZX+kEducNwAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH] Allow mini-os to unbind all evtchns

On 29/11/06 12:16, "Grzegorz Milos" <gm281@xxxxxxxxx> wrote:

> The patch looks good to me. I only have one comment: it would be good
> to have unbind_all_ports in the events header file.

It looked bogus to me. What if event channels are bound/unbound/bound
multiple times during the mini-os lifetime (can't happen right now, but
maybe in future). The port array will overflow. Perhaps it should be a
bitmap instead (set on bind; clear on unbind)?

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.