[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Allow mini-os to unbind all evtchns



I guess bitmap would work better. We won't have to rewrite the code once event channel unbounding is allowed... Shouldn't be too hard.

Thanks
Gregor

On 29 Nov 2006, at 12:25, Keir Fraser wrote:

On 29/11/06 12:16, "Grzegorz Milos" <gm281@xxxxxxxxx> wrote:

The patch looks good to me. I only have one comment: it would be good
to have unbind_all_ports in the events header file.

It looked bogus to me. What if event channels are bound/unbound/bound
multiple times during the mini-os lifetime (can't happen right now, but
maybe in future). The port array will overflow. Perhaps it should be a
bitmap instead (set on bind; clear on unbind)?

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.