Re: [Xen-devel] [PATCH] Enable uppercase letters to be entered in QEMU monitor terminal

["Daniel P. Berrange" <berrange@xxxxxxxxxx>]

On Wed, Nov 29, 2006 at 11:45:50AM +0000, Keir Fraser wrote:
> On 28/11/06 22:50, "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote:
> 
> > In the spirit of the original patch in changeset 10742, the attached patch
> > is the simplest solution to make shift keys work - it tracks the shift key
> > and caps lock key state. If both are active, or both inactive, then no
> > transform is made; If either one, or the other (but not both) are active,
> > then the letters a-z are transformed to A-Z, and vica-verca.
> 
> Doesn't this eat the shift/caps key events even when not in qemu monitor
> mode? What if the guest has shortcut key combos involving those keys, for
> example?

Re-checking the patch I believe its already doing the correct thing.

The do_key_event method is broken into 2 halfs. In the first half, the
keysyms are sent to either the guest OS, or the monitor. In the second
half the shift/caps/ctrl/alt state is being tracked. So the code I added
for tracking shift/caps does not interfere with the earlier code which
actually sends the key press to the guest OS.

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel