[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Enable uppercase letters to be entered in QEMU monitor terminal


  • To: "Daniel P. Berrange" <berrange@xxxxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Wed, 29 Nov 2006 16:09:32 +0000
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 29 Nov 2006 08:09:39 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AccT0MFF/6Nvun/DEducNwAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH] Enable uppercase letters to be entered in QEMU monitor terminal



On 29/11/06 15:48, "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote:

>> Doesn't this eat the shift/caps key events even when not in qemu monitor
>> mode? What if the guest has shortcut key combos involving those keys, for
>> example?
> 
> Re-checking the patch I believe its already doing the correct thing.
> 
> The do_key_event method is broken into 2 halfs. In the first half, the
> keysyms are sent to either the guest OS, or the monitor. In the second
> half the shift/caps/ctrl/alt state is being tracked. So the code I added
> for tracking shift/caps does not interfere with the earlier code which
> actually sends the key press to the guest OS.

Okay, I'll read the code more carefully. :-)

 -- keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.