Re: [Xen-devel] [PATCH] [XEND] fix vif IP specification broken in 12633:5bed7bc05c8a

[Alastair Tse <atse@xxxxxxxxxxxxx>]

On Tue, 2006-12-05 at 18:43 -0800, Brendan Cully wrote:
> > > > vif = ['ip=xxx.xxx.xxx.xxx'] hasn't worked since 12633 (at least with
> > > > Xen's nat scripts). The problem is that pre-12633, the IP field
> > > > returned from the config parser was a list, but now it is a string. So
> > > > ' '.join(ip) ends up sending 'x x x . x x x . x x x . x x x' to the
> > > > scripts, which were expecting less whitespace.
> > > 
> > > So does your fix mean that multiple IP addresses work again, or can we
> > > only have one address this way?  I'd prefer to fix the config parser if
> > > that's what's needed to support multiple IP addresses, since it
> > > certainly used to work.

I cleaned up the device SXP parsing in XendConfig which has the side
effect of fixing this IP address parsing problem in vif. The problem was
the SXP parsing went through two different paths depending on which
point the device configuration was inserted. This is in cs 12786.

The multiple IP address should still continue to work as before.

Cheers,

Alastair


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel