Re: [Xen-devel] [PATCH] Partial fix for compat build non-portability

[Keir Fraser <keir@xxxxxxxxxxxxx>]

On 10/1/07 17:37, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote:

> Still to be resolved is the pragma pack push issue; this is non-portable
> pragma only enabled on some targets, as it's intended for win32
> compatibility not something for general use. We should be wrapping each
> structure in a pragma pack(4) / pragma pack() pair, but trying to fix
> that makes my head hurt, and Jan isn't interested.

We only care about it working for the x86/64 target since that's the only
one that asserts CONFIG_COMPAT. Why would wrapping structs individually be
better than wrapping whole header files?

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel