RE: [PATCH][RESEND]RE: [Xen-devel] [PATCH] Fix softlockup issue after vcpu hotplug

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

>From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx]
>Sent: 2007年2月2日 2:42
>On 31/1/07 06:17, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:
>
>> So in 2.6.16, watchdog thread itself promises max timeout
>> to about 1s by hooking a timer, while In 2.6.18, the max timeout
>> value is volatile
>
>But the softlockup thread implementation has not changed between
>2.6.16 and
>2.6.18. The periodic delay is caused by the thread itself calling
>msleep_interruptible(1000) which should, as part of its implementation,
>queue up a timer. So this erratic behaviour on 2.6.18 is still worrying --

So, am I looking at wrong code? In 2.6.16:
        while (!kthread_should_stop()) {
                msleep_interruptible(1000);
                touch_softlockup_watchdog();
        }

While in 2.6.18:
        while (!kthread_should_stop()) {
                set_current_state(TASK_INTERRUPTIBLE);
                touch_softlockup_watchdog();
                schedule();
        }

I don't think same logic kept there. :-)

Thanks,
Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel