Re: [PATCH][RESEND]RE: [Xen-devel] [PATCH] Fix softlockup issue after vcpu hotplug

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 2/2/07 01:10, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:

> So, am I looking at wrong code? In 2.6.16:
> while (!kthread_should_stop()) {
>                 msleep_interruptible(1000);
>                 touch_softlockup_watchdog();
>         }
> 
> While in 2.6.18:
> while (!kthread_should_stop()) {
>                 set_current_state(TASK_INTERRUPTIBLE);
>                 touch_softlockup_watchdog();
>                 schedule();
>         }
> 
> I don't think same logic kept there. :-)

Fair point! I must have compared two 2.6.16 trees...

Well, that is interesting. I have no idea how SCHED_FIFO/sched_priority=99
interacts with timer wheels and/or tickless idle modes. I wonder why this
was changed at all? Perhaps a question for lkml...

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel