[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] linux/x86: Advertise which page table entries contain MFNs

  • To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Tue, 20 Feb 2007 09:52:08 +0000
  • Delivery-date: Tue, 20 Feb 2007 01:51:27 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcdU1MiuB4aKzMDIEdutSwAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH] linux/x86: Advertise which page table entries contain MFNs

On 13/2/07 15:14, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> .. and hence need to be (un)canonicalized during save/restore.
> The patch should apply without the page table handling adjustment one, yet
> the values passed in the new note assume that patch to be applied.
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

Could we just define _PAGE_PRESENT in the header file (it's not likely to
change!) rather than have to mess up another couple of header files to allow
inclusion in assembly files.

I see the need to change the ELFNOTE macro, but is the vararg macro syntax
ever unavailable when building Linux? Do you have to keep the old ELFNOTE
definition hanging around?

Why are the extra build rules required, which kill EXTRA_AFLAGS? Has it
something to do with trying to cleanly include pgtable.h?

I think I agree with the change to NEXT_PAGE() but the change belongs
upstream, not in our patches.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.