[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH] Use lib/swiotlb code for x86_64 SWIOTLB

  • To: xen-devel@xxxxxxxxxxxxxxxxxxx
  • From: "Langsdorf, Mark" <mark.langsdorf@xxxxxxx>
  • Date: Wed, 21 Feb 2007 18:09:34 -0600
  • Delivery-date: Wed, 21 Feb 2007 16:09:08 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcdRpdUBpZL8GnsOSIWI8Pw664F57gEb2uJg
  • Thread-topic: [Xen-devel] [PATCH] Use lib/swiotlb code for x86_64 SWIOTLB

> I can't see how this can work: First, the way the change is 
> done i386 will also use that file (and then
> arch/i386/kernel/swiotlb.c should also be deleted by
> the patch).

That wasn't intentional.  i386 can still use the 
arch/i386 code.

> Second, there's nothing Xen specific anymore in that file, not
> even the contiguous region creation (the sole difference to 
> plain 2.6.20 is the use of virt_to_bus/bus_to_virt). I think
> the first patch should be really just a move of
> arch/i386/kernel/swiotlb.c to lib/swiotlb-xen.c, nothing else.

This should be an improved version of lib/swiotlb.c as 
lib/swiotlb-xen.c, with correct code to make the mappings

-Mark Langsdorf
AMD, Inc.

Attachment: lib-swiotlb-on-x86_64.patch
Description: lib-swiotlb-on-x86_64.patch

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.