[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH][TOOLS] Reducing impactofdomainsave/restore/dump on Dom0

  • To: "Graham, Simon" <Simon.Graham@xxxxxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Fri, 23 Feb 2007 16:28:35 +0000
  • Delivery-date: Fri, 23 Feb 2007 08:27:59 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcdO73yfygbdSnxbR/2AnMRpBcbdNgAy2MewAXo9PloACVlAIAAAS21yAGSDywAAAszgRQ==
  • Thread-topic: [Xen-devel] [PATCH][TOOLS] Reducing impactofdomainsave/restore/dump on Dom0

On 23/2/07 15:13, "Graham, Simon" <Simon.Graham@xxxxxxxxxxx> wrote:

> Take 3 -- I've moved the flushing/fadvise-ing code into a common routine
> -- the only way I found to do this in line with other utilities was to
> make it inline in xc_private.h (since this is the only file included in
> both libxenctrl and libxenguest). The 'ifdef __linux__' stuff is now
> confined to this routine which is better...
> I've also left the fsync() in place -- I think it is necessary (and
> certainly does no harm).

Looks better. What is the -D_GNU_SOURCE for? It should probably at least be
limited to CFLAGS-$(CONFIG_Linux). And is it really needed in
xcutil/Makefile as well: if it's needed at all it should suffice to use it
when building the library that xcutil links against I would have thought?

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.