Re: [Xen-devel] [PATCH][TOOLS] Reducing impactofdomainsave/restore/dump on Dom0

[Keir Fraser <keir@xxxxxxxxxxxxx>]

On 23/2/07 15:13, "Graham, Simon" <Simon.Graham@xxxxxxxxxxx> wrote:

> Take 3 -- I've moved the flushing/fadvise-ing code into a common routine
> -- the only way I found to do this in line with other utilities was to
> make it inline in xc_private.h (since this is the only file included in
> both libxenctrl and libxenguest). The 'ifdef __linux__' stuff is now
> confined to this routine which is better...
> 
> I've also left the fsync() in place -- I think it is necessary (and
> certainly does no harm).

Looks better. What is the -D_GNU_SOURCE for? It should probably at least be
limited to CFLAGS-$(CONFIG_Linux). And is it really needed in
xcutil/Makefile as well: if it's needed at all it should suffice to use it
when building the library that xcutil links against I would have thought?

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel