RE: [Xen-devel] [PATCH][TOOLS] Reducing impactofdomainsave/restore/dump on Dom0

["Graham, Simon" <Simon.Graham@xxxxxxxxxxx>]

> Looks better. What is the -D_GNU_SOURCE for? It should probably at
> least be
> limited to CFLAGS-$(CONFIG_Linux). And is it really needed in
> xcutil/Makefile as well: if it's needed at all it should suffice to
use
> it
> when building the library that xcutil links against I would have
> thought?

1. You need _GNU_SOURCE to get posix_fadvise64 defined. I'm happy to
make
   the CFLAGS change (now that I know this facility exists ;-)

2. You need it in xcutil because this directory has code that includes
   xc_private.h -- this seems wrong/bad to me but I wasn't prepared
   to change it!

Simon

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel