[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH][TOOLS] Reducing impactofdomainsave/restore/dump on Dom0

  • To: "Keir Fraser" <keir@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Graham, Simon" <Simon.Graham@xxxxxxxxxxx>
  • Date: Fri, 23 Feb 2007 13:23:45 -0500
  • Delivery-date: Fri, 23 Feb 2007 10:23:01 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcdO73yfygbdSnxbR/2AnMRpBcbdNgAy2MewAXo9PloACVlAIAAAS21yAGSDywAAAszgRQAD8etA
  • Thread-topic: [Xen-devel] [PATCH][TOOLS] Reducing impactofdomainsave/restore/dump on Dom0

> Looks better. What is the -D_GNU_SOURCE for? It should probably at
> least be
> limited to CFLAGS-$(CONFIG_Linux). And is it really needed in
> xcutil/Makefile as well: if it's needed at all it should suffice to
> it
> when building the library that xcutil links against I would have
> thought?

1. You need _GNU_SOURCE to get posix_fadvise64 defined. I'm happy to
   the CFLAGS change (now that I know this facility exists ;-)

2. You need it in xcutil because this directory has code that includes
   xc_private.h -- this seems wrong/bad to me but I wasn't prepared
   to change it!


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.