[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] xenbus_dev_write and failed writes

  • To: John Levon <levon@xxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Fri, 02 Mar 2007 16:46:50 +0000
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 02 Mar 2007 08:46:09 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acdc6l+jnfzmCsjdEduwRgAX8io7RQ==
  • Thread-topic: [Xen-devel] xenbus_dev_write and failed writes

On 2/3/07 16:35, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote:

> Also, the BUG_ON in xenbusdrv_queue_reply() looks odd to me (in fact the
> whole function does). Are we really guaranteed that a reply message will
> be less than a page size? And it doesn't seem right to just stomp on the
> buffer contents if we wrap right past the consumer value.

Yes, it at least makes sense to discard the data rather than BUG. Actually
we should dynamically allocate up to some rather larger threshold than 4kB.
Will you fix this?

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.