Re: [Xen-devel] xenbus_dev_write and failed writes

[Keir Fraser <keir@xxxxxxxxxxxxx>]

On 2/3/07 16:35, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote:

> Also, the BUG_ON in xenbusdrv_queue_reply() looks odd to me (in fact the
> whole function does). Are we really guaranteed that a reply message will
> be less than a page size? And it doesn't seem right to just stomp on the
> buffer contents if we wrap right past the consumer value.

Yes, it at least makes sense to discard the data rather than BUG. Actually
we should dynamically allocate up to some rather larger threshold than 4kB.
Will you fix this?

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel