[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] xenbus_dev_write and failed writes



On Fri, Mar 02, 2007 at 04:46:50PM +0000, Keir Fraser wrote:

> > Also, the BUG_ON in xenbusdrv_queue_reply() looks odd to me (in fact the
> > whole function does). Are we really guaranteed that a reply message will
> > be less than a page size? And it doesn't seem right to just stomp on the
> > buffer contents if we wrap right past the consumer value.
> 
> Yes, it at least makes sense to discard the data rather than BUG. Actually
> we should dynamically allocate up to some rather larger threshold than 4kB.
> Will you fix this?

I doubt I'll have time to fix /both/ kernels, sorry...

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.