[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Xen-devel] Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation
- To: Ingo Molnar <mingo@xxxxxxx>
- From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
- Date: Fri, 16 Mar 2007 12:00:49 +0000
- Cc: Zachary Amsden <zach@xxxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Ian Pratt <ian.pratt@xxxxxxxxxxxxx>, Andi Kleen <ak@xxxxxx>, Rusty Russell <rusty@xxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Adrian Bunk <bunk@xxxxxxxxx>, Chris Wright <chrisw@xxxxxxxxxxxx>, virtualization@xxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Christian Limpach <Christian.Limpach@xxxxxxxxxxxx>
- Delivery-date: Mon, 19 Mar 2007 03:45:40 -0700
- List-id: Xen developer discussion <xen-devel.lists.xensource.com>
- Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Andi Kleen <ak@xxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Chris Wright <chrisw@xxxxxxxxxxxx>, Zachary Amsden <zach@xxxxxxxxxx>, Rusty Russell <rusty@xxxxxxxxxxxxxxx>, Ian Pratt <ian.pratt@xxxxxxxxxxxxx>, Christian Limpach <Christian.Limpach@xxxxxxxxxxxx>, Adrian Bunk <bunk@xxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>
On Fri, Mar 16, 2007 at 10:14:11AM +0100, Ingo Molnar wrote:
>
> * Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
>
> > Core Xen Implementation
> >
> > This patch is a rollup of all the core pieces of the Xen
> > implementation, including booting, memory management, interrupts, time
> > and so on.
>
> > --- a/arch/i386/kernel/head.S
> > +++ b/arch/i386/kernel/head.S
> > @@ -535,6 +535,10 @@ unhandled_paravirt:
> > ud2
> > #endif
> >
> > +#ifdef CONFIG_XEN
> > +#include "../xen/xen-head.S"
> > +#endif
>
> i'd suggest to remove the #ifdef and push it into xen-head.S.
Even better would be an explanation of why this needs to be included
at all. Life would be much simpler if this was simply a totally
separate file.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
