[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 0/3] [RFC] User-space grant table device

  • To: Derek Murray <Derek.Murray@xxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Mon, 19 Mar 2007 14:00:29 +0000
  • Delivery-date: Mon, 19 Mar 2007 06:59:42 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcdqLvOFMi0hVNYiEduRVQAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH 0/3] [RFC] User-space grant table device

On 19/3/07 10:40, "Derek Murray" <Derek.Murray@xxxxxxxxxxxx> wrote:

> 1. gntdev.patch: This is the main driver, and associated header file.
> 2. libxc-changes.patch: These are the libxc functions for accessing
> the driver.
> 3. linux-changes.patch: These contain the necessary changes to linux
> (in effect, adding a hook to the vm_operations_struct that is called
> by the unmap_page_range function) for unmapping grants before the
> page table is destroyed.

1. The patches are malformed (don't apply). It might be best to send the
patches at plain-text attachments to prevent mangling by your email client.
2. Dependencies should be listed in the right order. So your patch 3 should
be patch 1, since it is required by the grant-table device.
3. Just looking at linux-changes.patch, I think the new interface function's
semantics need to be clearer. Do you really mean for the hook function to be
called *and* for unmap_page_range() to do the usual zap_pud_range() work?
Should the hook function return anything? What about responsibility for
synchronising TLBs?

 -- Keir


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.