Re: [Xen-devel] [PATCH 0/3] [RFC] User-space grant table device

[Derek Murray <Derek.Murray@xxxxxxxxxxxx>]

Keir Fraser wrote:
> 1. The patches are malformed (don't apply). It might be best to send the
> patches at plain-text attachments to prevent mangling by your email client.
> 2. Dependencies should be listed in the right order. So your patch 3 should
> be patch 1, since it is required by the grant-table device.

Sorry about those: I'll fix them in a subsequent repost.

> 3. Just looking at linux-changes.patch, I think the new interface function's
> semantics need to be clearer. Do you really mean for the hook function to be
> called *and* for unmap_page_range() to do the usual zap_pud_range() work?
> Should the hook function return anything? What about responsibility for
> synchronising TLBs?

Might it be better to replace this hook with something that operates on the PTE 
(rather than vm_area) level? Thus the hook could be called from 
zap_pte_range(), and this would harness all the TLB synchronisation that is 
normally employed.

I'm not sure that the hook function should return anything: as far as I 
understand, the unmap-grant hypercall should not fail, and, if it does, I don't 
see how we can recover from that.

Regards,

Derek.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel