[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 0/3] [RFC] User-space grant table device

On 22 Mar 2007, at 02:28, Isaku Yamahata wrote:
When auto translate physmap mode, grant table works based on
pseudo physical address space. not virtual address space.
Please see gnttab_set_map/unmap_op() using __pa().
It is up to the guest kernel to map the pseudo physical address
to kernel/user virtual address space using kernel functionality.

Given that Linux adopts 1:1 mapping between pseudo physical address
space and kernel virtual address space, there is

Both setting vm_private_data and calling vm_insert_page are necessary.
vm_insert_page() is the counter part of GNTMAP_application_map for
auto translated phymap mode.
I may be worng because I haven't taken closer look of your code, though.

Okay, the reimplementation of the driver following the blktap model seems to be going well, and has also managed to tease out a couple of bugs. I'll post an updated patch probably early next week.

I'm willing to review/test.
Do you have any testing program? Can you provide it?
I may need it when test.

Thanks for your offer! This would be very useful. My current plan is to test it on x86_32 with shadow paging turned off and then on, and once this works I will resubmit the patch. My testing program is in two parts: one based on Mini-OS, which I use to have a domain that grants a few pages, and the other which runs in dom0 and calls my modified libxc. I can supply this if necessary.


Derek Murray.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.