[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [Patch][RFC] correct retry limit of balloon

Hi, all

Balloon wait free memory become enough need memory.
The waiting time is retries * rlimit. When retries =0,
rlimit add ((need_mem - free_mem)/1024/1024) * RETRY_LIMIT_INCR once for all.
But log.debug message show retries. (Why? retries is always 0.)

So I think the following patch is what you really want to do.
What do you think?

Signed-off-by: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>

diff -r 2d918219f234 tools/python/xen/xend/balloon.py
--- a/tools/python/xen/xend/balloon.py  Thu Mar 22 18:41:15 2007 +0000
+++ b/tools/python/xen/xend/balloon.py  Sun Mar 25 09:38:02 2007 +0900
@@ -127,7 +127,7 @@ def free(need_mem):
                           free_mem, need_mem)
-            if retries == 0:
+            if retries != 0:
                 rlimit += ((need_mem - free_mem)/1024/1024) * RETRY_LIMIT_INCR
                 log.debug("Balloon: %d KiB free; %d to scrub; need %d; 
retries: %d.",
                           free_mem, scrub_mem, need_mem, rlimit)

Best Regards,

Akio Takebe

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.