RE: [Xen-devel] [Patch][RFC] correct retry limit of balloon

["Puthiyaparambil, Aravindh" <aravindh.puthiyaparambil@xxxxxxxxxx>]

> But log.debug message show retries. (Why? retries is always 0.)

retries is not always 0 especially on large systems. And it is
incremented later on in the loop. I think patch should explain things
more clearly.

http://xenbits.xensource.com/xen-unstable.hg?rev/93db1b536f38

Thanks
Aravindh

> So I think the following patch is what you really want to do.
> What do you think?
> 
> Signed-off-by: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
> 
> diff -r 2d918219f234 tools/python/xen/xend/balloon.py
> --- a/tools/python/xen/xend/balloon.py  Thu Mar 22 18:41:15 2007 +0000
> +++ b/tools/python/xen/xend/balloon.py  Sun Mar 25 09:38:02 2007 +0900
> @@ -127,7 +127,7 @@ def free(need_mem):
>                            free_mem, need_mem)
>                  return
> 
> -            if retries == 0:
> +            if retries != 0:
>                  rlimit += ((need_mem - free_mem)/1024/1024) *
> RETRY_LIMIT_INCR
>                  log.debug("Balloon: %d KiB free; %d to scrub; need
%d;
> retries: %d.",
>                            free_mem, scrub_mem, need_mem, rlimit)
> 
> Best Regards,
> 
> Akio Takebe
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel