[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] rcu readers - remove dummy lock object


  • To: <ncmike@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Mon, 26 Mar 2007 19:20:39 +0100
  • Delivery-date: Mon, 26 Mar 2007 11:18:53 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acdv03Sys42bntvGEdu/NgAWy6hiGQ==
  • Thread-topic: [Xen-devel] [PATCH] rcu readers - remove dummy lock object

On 25/3/07 20:58, "Mike D. Day" <ncmike@xxxxxxxxxx> wrote:

> rcu_read_lock and rcu_read_unlock in Xen are empty macros used to
> document the use of rcu techniques. The Xen definition for rcu readers
> uses a dummy lock object. The upstream linux code has since redefined
> rcu reader lock routines to omit the dummy lock object. This makes rcu
> read locking appear similar to memory barriers and other instructions
> that do not take an operand.

I added the dummy 'lock' object explicitly, as it makes it clearer what
object is protected by the critical section. The fact that the operations
and the dummy lock typedef both have rcu in the name should avoid confusion
with spinlocks.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.