[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/12] Add suspend/resume to devices owned by Xen


  • To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Mon, 11 Jun 2007 11:08:38 +0100
  • Delivery-date: Mon, 11 Jun 2007 03:06:42 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AceW+19nrz3vWNtATFekqBOc/y2imQVFRs2K
  • Thread-topic: [Xen-devel] [PATCH 1/12] Add suspend/resume to devices owned by Xen

On 15/5/07 15:14, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:

> +    now = get_cmos_time();
> +    sleep_diff = now - sleep_start;
> +    wc_sec = now;
> +    jiffies += sleep_diff * HZ;
> +    
> +    stime_platform_stamp += SECONDS(sleep_diff);

Is this correct? I think you should either increment wc_sec by sleep_diff,
*or* increment stime by SECONDS(sleep_diff). If you do both, wall clock will
jump by twice the amount it should have done, won't it (because wc_sec is
wallclock time when stime=0)?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.