RE: [Xen-devel] [PATCH 1/12] Add suspend/resume to devices owned by Xen

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

>From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx]
>Sent: 2007年6月11日 18:09
>On 15/5/07 15:14, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:
>
>> +    now = get_cmos_time();
>> +    sleep_diff = now - sleep_start;
>> +    wc_sec = now;
>> +    jiffies += sleep_diff * HZ;
>> +
>> +    stime_platform_stamp += SECONDS(sleep_diff);
>
>Is this correct? I think you should either increment wc_sec by sleep_diff,
>*or* increment stime by SECONDS(sleep_diff). If you do both, wall clock
>will
>jump by twice the amount it should have done, won't it (because wc_sec
>is
>wallclock time when stime=0)?
>
> -- Keir

You're right that wc_sec shouldn't be updated. I have a patch pending 
in house to fix it actually, but wait for right time to submit. :-) Thanks for 
review and sorry for no notification earlier.

Thanks,
Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel