[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] A wrong assert in get_ioreq()?

  • To: xen-devel@xxxxxxxxxxxxxxxxxxx
  • From: "Paul Samon" <paul.samon@xxxxxxxxx>
  • Date: Wed, 4 Jul 2007 19:05:20 +0800
  • Delivery-date: Wed, 04 Jul 2007 04:03:13 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:mime-version:content-type; b=TXCzOOL1K7bw0IbIxMac5RzUKAtZstdZk5vc2NlF6GM8DMVf3lFw1XMyn9c3xzI06piJkT4fb3VZdWSw3DRSziWvZnoN1N0ZPSDe/HXdd2O8VA/ujaM9BrQzYSven8gTtmb7+8WJgskupRW2Wvw+COQuN7FhfJKPXZsMg+4Ad0c=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

In the function get_ioreq(),  there is a line:
    ASSERT((v == current) || spin_is_locked(&d->arch.hvm_domain.ioreq.lock ));
I don't think it should be
    ASSERT(v == current).
we don't get the lock first, and I think we needn't it.
Am I missing something?
Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.