[Xen-ia64-devel] Re: [Xen-devel] [Patch] ARCH_HAS_DEV_MEM patch for Xwindow on IA64machine

[Jun Kamada <kama@xxxxxxxxxxxxxx>]

Hi, Jan-san,

On Wed, 04 Jul 2007 13:04:50 +0100
"Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
> >--- a/drivers/xen/Makefile   Thu Jun 21 15:12:20 2007 +0900
> >+++ b/drivers/xen/Makefile   Thu Jun 21 15:13:21 2007 +0900
> >@@ -5,9 +5,9 @@ obj-y        += xenbus/
> > obj-y       += xenbus/
> > obj-y       += gntdev/
> > obj-y       += balloon/
> >-obj-y       += char/
> > 
> > obj-y       += util.o
> >+obj-$(CONFIG_XEN_DEVMEM)            += char/
> > obj-$(CONFIG_XEN_BLKDEV_BACKEND)    += blkback/
> > obj-$(CONFIG_XEN_BLKDEV_TAP)                += blktap/
> > obj-$(CONFIG_XEN_NETDEV_BACKEND)    += netback/
> 
> This is certainly wrong. Even if driver/xen/char/ currently only has a
> single file, you should descend into that directory. The conditional
> (if needed at all) should then be in driver/xen/char/Makefile.

I modified the patch acording to your comment.

Thanks,

-----
Jun Kamada
Linux Technology Development Div.
Server Systems Unit
Fujitsu Ltd.
kama@xxxxxxxxxxxxxx

Attachment: ifdef_arch_has_dev_mem.patch
Description: Binary data

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel