Re: [Xen-devel] [PATCH] Allow programatic iomem permissions

[Kieran Mansley <kmansley@xxxxxxxxxxxxxx>]

On Wed, 2007-07-18 at 13:46 +0100, Keir Fraser wrote:
> On 18/7/07 12:29, "Kieran Mansley" <kmansley@xxxxxxxxxxxxxx> wrote:
> > If this patch is acceptable (and once better tested) I'll repost with it
> > signed off, together with the change to redefine the
> > grant_operation_permitted macro, and the iomem permission patch that
> > prompted this in the first place.
> 
> I'll add it to my to-look-at list. It might be a little while.

I'm glad you didn't look at it straightaway as I've found a little bug
during testing.  A new patch is attached; the change was as follows:

--- a/xen/common/grant_table.c  Wed Jul 25 10:33:15 2007 +0100
+++ b/xen/common/grant_table.c  Wed Jul 25 13:59:10 2007 +0100
@@ -571,7 +571,7 @@ __gnttab_unmap_common_complete(struct gn
             put_page_and_type(mfn_to_page(op->frame));
     }

-    if ( (op->flags & (GNTMAP_device_map|GNTMAP_host_map)) == 0 )
+    if ( (op->map->flags & (GNTMAP_device_map|GNTMAP_host_map)) == 0 )
     {
         op->map->flags = 0;
         put_maptrack_handle(ld->grant_table, op->handle);


Kieran

Attachment: unmap_tlb_fix
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel