[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Fix 64-bit foreign header check


  • To: John Levon <john.levon@xxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Thu, 16 Aug 2007 08:15:45 +0100
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 16 Aug 2007 00:12:15 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acff1UMXgYSGwkvIEdyKOAAWy6hiGQ==
  • Thread-topic: [Xen-devel] [PATCH] Fix 64-bit foreign header check

On 15/8/07 17:08, "John Levon" <john.levon@xxxxxxx> wrote:

>> Hmmm... Well varying COMPILE_ARCH when the compile arch is not actually
>> changing seems dodgy to me.
>> 
>> In any case, binaries that run on the compile host should build with
>> HOSTCC/HOSTCFLAGS. That seems a pretty simple and obvious rule that I do not
>> want to introduce exceptions to.
> 
> Can you please explain what you want us to do.

When you modify COMPILE_ARCH to x86_64, you should also modify HOSTCFLAGS to
include -m64. We can set HOSTCC/HOSTCFLAGS with '?=' assignment for this
purpose, in Config.mk. Or, perhaps better, you can set both COMPILE_ARCH and
HOSTCC/HOSTCFLAGS as you like in config/SunOS.mk based on XEN_TARGET_ARCH,
if that's always the sane thing to do on Solaris.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.