Re: unaligned and page-crossing writes in shadow emulate callbacks (was Re: [Xen-devel] Question about alignment check in sh_x86_emulate_write)

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

Hi, 

At 11:06 +0800 on 11 Dec (1197371200), Su, Disheng wrote:
> There is a minor bug in your patch:
> "sh_ctxt->force_write_access == !!(is_hvm_vcpu(v) && !hvm_wp_enabled(v));"

Oops. :|  I'm surprised gcc let me away wth that, actually.

> With the fix, it solves the virus-scanner's problem:)

Unfortunately, there's a more subtle bug in there too (or possibly in
some earlier change that's gone unnoticed) that's sending Windows XP
occasionally to its doom with a pagefault when the IRQL is too high.
I'm glad to hear that it solves the intended problems, though. :)

I'll fold in your idea of adjusting mandatory_flags instead of
special-casing the failure.

Thanks,

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Citrix Systems.
[Company #5334508: XenSource UK Ltd, reg'd c/o EC2Y 5EB, UK.]

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel