[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: unaligned and page-crossing writes in shadow emulate callbacks (was Re: [Xen-devel] Question about alignment check in sh_x86_emulate_write)


  • To: "Tim Deegan" <Tim.Deegan@xxxxxxxxxx>
  • From: "Su, Disheng" <disheng.su@xxxxxxxxx>
  • Date: Tue, 11 Dec 2007 11:06:40 +0800
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Trolle Selander <trolle.selander@xxxxxxxxx>
  • Delivery-date: Mon, 10 Dec 2007 19:08:50 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acg4FHAAuoakI64nTZCzSmd2FAUyZgDjYRKA
  • Thread-topic: unaligned and page-crossing writes in shadow emulate callbacks (was Re: [Xen-devel] Question about alignment check in sh_x86_emulate_write)

Tim Deegan wrote:
> Hi,
> 
> At 13:33 +0000 on 04 Dec (1196775199), Tim Deegan wrote:
>> Yes, but you'll probably find you need page-crossing support as well
>> if you're emulating arbitrary memory writes.  I believe we have a
>> patch somewhere that does that; I'll dig it out and polish it up for
>> -unstable. 
> 
> Attached.  I took the opportunity to tidy up a bit and move more
> shared code out of the write/cmpxchg/cmpxchg8b callbacks into
> helpers.  This is smoke-tested but I don't have a test case for your
> virus-scanner's behaviour.  Can you check that (a) it seems sane for
> what you want, and (b) it actually does something useful?
> 
> Cheers,
> 
> Tim.
Sorry for the late(missing your email...) 
There is a minor bug in your patch:
"sh_ctxt->force_write_access == !!(is_hvm_vcpu(v) &&
!hvm_wp_enabled(v));"
With the fix, it solves the virus-scanner's problem:)


Best Regards,
Disheng, Su

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.