[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: RFC: unaligned and page-crossing writes in shadow emulate callbacks (was Re: [Xen-devel] Question about alignment check in sh_x86_emulate_write)
- To: "Tim Deegan" <Tim.Deegan@xxxxxxxxxx>
- From: "Trolle Selander" <trolle.selander@xxxxxxxxx>
- Date: Mon, 10 Dec 2007 14:54:22 +0100
- Cc: "Su, Disheng" <disheng.su@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 10 Dec 2007 05:55:01 -0800
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=x9iRoNWm2RfCn6mGnAF+O0B6pi/R1Elx64+8Uw2zagvAzr1eX/nDCFgk/RjjZzVI+plWpQvr4pUOjnGful+FtMPkXpbCyhbpOehw0jyS6xRL9Ix0u5hxperY50aAHnPSbLwlHu+LvfrDOX0sPPCtMnkUaq1GUhsBFiyb7eS+hKI=
- List-id: Xen developer discussion <xen-devel.lists.xensource.com>
This fixes the issue for the OS/2 case, at least.
On Dec 6, 2007 3:27 PM, Tim Deegan < Tim.Deegan@xxxxxxxxxx> wrote:
Hi,
At 13:33 +0000 on 04 Dec (1196775199), Tim Deegan wrote:
> Yes, but you'll probably find you need page-crossing support as well if
> you're emulating arbitrary memory writes. I believe we have a patch
> somewhere that does that; I'll dig it out and polish it up for -unstable.
Attached. I took the opportunity to tidy up a bit and move more shared
code out of the write/cmpxchg/cmpxchg8b callbacks into helpers. This is
smoke-tested but I don't have a test case for your virus-scanner's
behaviour. Can you check that (a) it seems sane for what you want, and
(b) it actually does something useful?
Cheers,
Tim.
--
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Citrix Systems.
[Company #5334508: XenSource UK Ltd, reg'd c/o EC2Y 5EB, UK.]
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
