[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH][2 of 3] GDB serial port debugging: Respect opt_watchdog flag when resuming a debug session

  • To: xen-devel@xxxxxxxxxxxxxxxxxxx
  • From: "Dan Doucette" <doucette.daniel@xxxxxxxxx>
  • Date: Wed, 19 Dec 2007 14:45:22 -0800
  • Delivery-date: Wed, 19 Dec 2007 14:45:46 -0800
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type; b=fgM94C4KzHlbMxwSeVWoPtCMDvVlEYgAxYgVv30qeE5Yc4mowJYc+fKqd3x0+33KcxwFnlbocEs+1CLGA2g+XnYCtQo5TMaxPKKzXZXTKzeEKf6xcXlIZ0oF1zntbaiLCc5hOS+bd3TTMmMwlGaeFKlKI+zEn7cNEmH+gtAOJ2E=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

When trap_to_gdb in common/gdbstub.c returns, it calls watchdog_enable().  However, the watchdog functionality is an option controlled in arch/x86/setup.c using the opt_watchdog boot parameter, and currently defaults to 'off'.  When the user resumes from a gdb session over the serial port, the watchdog will be enabled regardless of the 'opt_watchdog' flag.  This patch addresses this issue by propagating the optional parameter to arch/x86/nmi.c and conditionally enabling/disabling the watchdog based on the value of the now global 'opt_watchdog' flag.
% diffstat opt_watchdog_patch
 nmi.c   |   11 ++++++++++-
 setup.c |    5 ++---
 2 files changed, 12 insertions(+), 4 deletions(-)
Signed-off-by:  Dan Doucette <doucette.daniel@xxxxxxxxx>

Attachment: opt_watchdog_patch
Description: Text document

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.