Re: [Xen-devel] [PATCH]Fixes for overflowed calculation in vHPET

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 4/1/08 03:21, "Shan, Haitao" <haitao.shan@xxxxxxxxx> wrote:

> This patch will fix the bugs in hpet_set_timer. Currently in hpet_tick_to_ns, the approach is multiplying first, which easily causes overflow when tick is quite large. The patch cannot handle arbitrate large ticks duo to the precision requirement and 64bit's value range. But by optimize the equation, a larger ticks than current code can be supported. Also an overflow check is added before the calculation. 
> This patch will also fix the wrong handling of wrap around case when timer is in 64bit mode. 

What’s wrong with the handling of the wrap-around case? It looks okay to me.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel