Re: [Xen-devel] That xenstored console leak...

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 14/1/08 21:48, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote:

>> Yes, device controllers clean up by deleting /vm/<uuid>/path/to/device. This
>> aliases with the new domain's device information (because they're really the
>> same vm) and so when the old domain is cleaned up the new domain loses
>> information. Disambiguating with an extra level of indirection seemed the
>> simplest fix for this. I'm not sure why this leads to xenstore leaks.
>> 
>> When a domain is finally garbage collected in xend, perhaps we should delete
>> its entire /vm/<uuid>/<unique-number>? That would seem a nice and reasonable
>> catch-all.
> 
> The lack of the latter explains the former - because each instance has a
> unique /vm path, there's nothing that ever cleans up the older path
> contents (image etc.).  Right?

I don't understand what you mean. There's no code to delete the entire /vm
path, regardless of whether the path is /vm/<uuid>/ or /vm/<uuid>-<number>
(I'm pretty sure). And if there was, why would it be affected by the detail
of what happens to be the domain's /vm path anyway?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel