[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] That xenstored console leak...

On Mon, Jan 14, 2008 at 09:54:50PM +0000, Keir Fraser wrote:

> >> Yes, device controllers clean up by deleting /vm/<uuid>/path/to/device. 
> >> This
> >> aliases with the new domain's device information (because they're really 
> >> the
> >> same vm) and so when the old domain is cleaned up the new domain loses
> >> information. Disambiguating with an extra level of indirection seemed the
> >> simplest fix for this. I'm not sure why this leads to xenstore leaks.
> >> 
> >> When a domain is finally garbage collected in xend, perhaps we should 
> >> delete
> >> its entire /vm/<uuid>/<unique-number>? That would seem a nice and 
> >> reasonable
> >> catch-all.
> > 
> > The lack of the latter explains the former - because each instance has a
> > unique /vm path, there's nothing that ever cleans up the older path
> > contents (image etc.).  Right?
> I don't understand what you mean. There's no code to delete the entire /vm
> path, regardless of whether the path is /vm/<uuid>/ or /vm/<uuid>-<number>
> (I'm pretty sure).

The old code re-used the same /vm/<uuid>/ path, so there was no leak.
The new code creates a completely new /vm/<uuid>-<number> path, leaking the
old one (/vm/<uuid>-<oldnumber>).

Am I missing something obvious here?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.